Properly build text node for junit output formatter#7917
Merged
samsonasik merged 1 commit intorectorphp:mainfrom Feb 25, 2026
Merged
Properly build text node for junit output formatter#7917samsonasik merged 1 commit intorectorphp:mainfrom
samsonasik merged 1 commit intorectorphp:mainfrom
Conversation
Member
|
/cc @VitalyArt since you originally create the junit formatter, could you verify it? Thank you. |
Contributor
|
@samsonasik Yes, this fixes the problem. Before fix (invalid xml): <?xml version="1.0" encoding="UTF-8"?>
<testsuites><testsuite name="rector"><testcase file="example.php" name="example.php:1"><error type="TernaryToNullCoalescingRector">--- Original
+++ New
@@ -1,3 +1,3 @@
<?php
-$foo = isset($bar) ? $bar : ($baz & $qux);
+$foo = $bar ?? ($baz & $qux);
</error></testcase></testsuite></testsuites>After fix: <?xml version="1.0" encoding="UTF-8"?>
<testsuites><testsuite name="rector"><testcase file="example.php" name="example.php:1"><error type="TernaryToNullCoalescingRector">--- Original
+++ New
@@ -1,3 +1,3 @@
<?php
-$foo = isset($bar) ? $bar : ($baz && $qux);
+$foo = $bar ?? ($baz && $qux);
</error></testcase></testsuite></testsuites> |
samsonasik
approved these changes
Feb 25, 2026
Member
|
Thank you @VitalyArt for verify, and thank you @brandonja991 for the fix. @TomasVotruba let's merge this ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#9674
Fixes issue when diff contains ampersands causing XML produced to result in parse error due to unescaped ampersands.